Skip to content

Fix data chunking bug in WLANHandler.write #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

Fix data chunking bug in WLANHandler.write #246

merged 1 commit into from
Feb 20, 2025

Conversation

bessman
Copy link
Collaborator

@bessman bessman commented Feb 20, 2025 •
edited
Loading

This bug currently does not trigger because all callers of WLANHandler.write use a smaller buf_size than it.

Summary by Sourcery

Bug Fixes:

  • Fixed a bug in WLANHandler.write that caused incorrect data chunking when the size of the data to be sent exceeds the buffer size.

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Feb 20, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request fixes a bug in the WLANHandler.write method where data chunking was not correctly handled when the input data size was larger than the buffer size. The fix involves correcting the slicing logic to ensure that the correct chunk of data is sent in each iteration of the loop.

Sequence diagram for WLANHandler.write data chunking

sequenceDiagram
    participant WLANHandler
    participant Socket

    WLANHandler->>WLANHandler: remaining = len(data)
    loop while remaining > 0
        WLANHandler->>WLANHandler: chunk = data[sent : sent + min(remaining, buf_size)]
        WLANHandler->>Socket: send(chunk)
        Socket-->>WLANHandler: bytes_sent
        WLANHandler->>WLANHandler: sent += bytes_sent
        WLANHandler->>WLANHandler: remaining -= len(chunk)
    end
Loading

File-Level Changes

Change Details Files
Fixed a bug in WLANHandler.write that caused incorrect data chunking when the input data size exceeds the buffer size.
  • Corrected the chunk slicing logic to ensure the correct portion of data is sent in each iteration.
 pslab/connection/wlan.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Feb 20, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bessman - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Good job catching this bug before it became a problem.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@bessman bessman merged commit e1066ea into fossasia:development Feb 20, 2025
2 checks passed
@bessman bessman deleted the development branch February 20, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bessman